Update NC-fluxes for the SWE-Wet/Dry#53
Update NC-fluxes for the SWE-Wet/Dry#53andrewwinters5000 merged 1 commit intotrixi-framework:mainfrom
Conversation
andrewwinters5000
left a comment
There was a problem hiding this comment.
The changes to code look good and it all should work. Because the CI will not run until Trixi v0.8.7 is released did you run the tests locally that everything passes?
Yes, I checked that the tests pass locally. |
|
I'll re-open this to trigger CI again using the new release of Trixi.jl |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
==========================================
- Coverage 99.27% 99.27% -0.01%
==========================================
Files 61 61
Lines 2638 2630 -8
==========================================
- Hits 2619 2611 -8
Misses 19 19 ☔ View full report in Codecov by Sentry. |
|
Thanks! Looks like it works. It would be great to get a new release including this somewhat soon so that Trixi.jl downstream CI passes again. |
In trixi-framework/Trixi.jl#2038, the definition of
flux_nonconservative_wintermeyer_etalhas been changed and the methodflux_nonconservative_ersing_etalis removed fromTrixi.jl.Therefore in this PR
flux_nonconservative_ersing_etalis now exported byTrixiShallowWater.jland some test values had to be updated. Sinceflux_nonconservative_ersing_etalmoves to TrixiShallowWater.jl the lower compat bound forTrixi.jlis also updated.Needs to be merged after trixi-framework/Trixi.jl#2038