-
Notifications
You must be signed in to change notification settings - Fork 9
Setup initial documentation #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup initial documentation #54
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54 +/- ##
=======================================
Coverage 99.32% 99.32%
=======================================
Files 60 60
Lines 2794 2794
=======================================
Hits 2775 2775
Misses 19 19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrewwinters5000 very nice tutorial!
I think it's looks quite good already. I have a few smaller comments and a suggestion how we could streamline the tutorial by setting up everything for the final time directly.
Co-authored-by: Patrick Ersing <[email protected]>
Co-authored-by: Patrick Ersing <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small comments as we move closer to the finish line for the docs.
Co-authored-by: Andrew Winters <[email protected]>
…ater.jl into initial_docs
Co-authored-by: Andrew Winters <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one final comment and I will push an update to the authors list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Great work @patrickersing ! I think we are ready to pull the ripcord
This PR creates the initial documentation for
TrixiShallowWater.jl
.ToDo:
something with multiple layers