Only report FeatureEnvy for instance methods #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drenmi
reviewed
Jun 13, 2018
| @@ -247,4 +247,49 @@ def alfa(bravo) | |||
|
|
|||
| expect(src).not_to reek_of(:FeatureEnvy) | |||
| end | |||
|
|
|||
| it 'does not report on class methods defined by opening the metaclass' do | |||
| src = <<-EOS | |||
There was a problem hiding this comment.
If you use the name of the language as a delimiter (i.e. RUBY), most editors will provide syntax highlighting for the code example. 🙂
There was a problem hiding this comment.
Oh nice. I'm leaving it as-is for now to match the rest of the specs. Then we can change all of them in one go.
There was a problem hiding this comment.
If you use the name of the language as a delimiter (i.e. RUBY), most editors will provide syntax highlighting for the code example
Super cool indeed, didn't know that!
troessner
reviewed
Jun 13, 2018
| EOF | ||
|
|
||
| expect(src).not_to reek_of(:FeatureEnvy) | ||
| end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1337.
This restores the symmetry with UtilityFunction, which also reports only on instance methods.