Fix: clang_getClangVersion() does not return ctypes.c_char_p#155
Open
kienanstewart wants to merge 1 commit intotrolldbois:masterfrom
Open
Fix: clang_getClangVersion() does not return ctypes.c_char_p#155kienanstewart wants to merge 1 commit intotrolldbois:masterfrom
clang_getClangVersion() does not return ctypes.c_char_p#155kienanstewart wants to merge 1 commit intotrolldbois:masterfrom
Conversation
The return value of `clang_getClangVersion()` is a CXString structure. Depending on the architecture the structure can be returned on the stack or via a register. When assuming it is a `ctypes.c_char_p`, the ctypes FFI call will segfault upon return on armhf due to not properly handling how the architecture is returning the data. Properly setting the return type for `clang_getClangVersion()` will avoid the segfault. Signed-off-by: Kienan Stewart <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The return value of
clang_getClangVersion()is a CXString structure. Depending on the architecture the structure can be returned on the stack or via a register.When assuming it is a
ctypes.c_char_p, the ctypes FFI call will segfault upon return on armhf due to not properly handling how the architecture is returning the data.Properly setting the return type for
clang_getClangVersion()will avoid the segfault.