[test] Respect user's CFLAGS more than our own added ones; remove EXTRA_CFLAGS #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RA_CFLAGS See also commit 747bb96, from ten years ago, which first made us respect the user's CFLAGS here at all. But we still appended our own flags (e.g. `-I../src -Wall`) to the end of the command line, so the user couldn't override any of ours with their own. GNU's guidelines seem like a good way to go: > https://www.gnu.org/prep/standards/html_node/Command-Variables.html The EXTRA_CFLAGS variable was introduced to force options to the end of the command line. Now that the user's CFLAGS are properly at the end, we can replace our use of EXTRA_CFLAGS with just CFLAGS. All of this affects only how the tests are compiled, not anything about the library itself.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also commit 747bb96, from ten years ago, which first made us respect the user's CFLAGS here at all. But we still appended our own flags (e.g.
-I../src -Wall) to the end of the command line, so the user couldn't override any of ours with their own.GNU's guidelines seem like a good way to go:
The EXTRA_CFLAGS variable was introduced to force options to the end of the command line. Now that the user's CFLAGS are properly at the end, we can replace our use of EXTRA_CFLAGS with just CFLAGS.
All of this affects only how the tests are compiled, not anything about the library itself.