Skip to content

update workflow registry to JFrog #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 4, 2024
Merged

update workflow registry to JFrog #19

merged 4 commits into from
Oct 4, 2024

Conversation

DeeAjayi
Copy link
Contributor

No description provided.

Copy link
Contributor

@dunefro dunefro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3

- name: Log in to JFrog Artifactory
uses: docker/login-action@v2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to v3 action

- name: Build and push Docker image
uses: docker/build-push-action@v6
env:
REGISTRY: ${{ steps.login-ecr.outputs.registry }}
REGISTRY_ALIAS: truefoundrycloud
REGISTRY: tfy.jfrog.io
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this to env variable at a global level

@DeeAjayi DeeAjayi merged commit f1f97b3 into main Oct 4, 2024
4 checks passed
@sachincool
Copy link
Member

the workflow failed
https://github.com/truefoundry/elasti/actions/runs/11280683886
matrix is unresolvable before the job has begun.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants