Skip to content

[DRAFT] 0.8.0 Add support for server side "iscsi defer" #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

mrstux
Copy link
Collaborator

@mrstux mrstux commented Jun 6, 2025

Adds support to the tool to take additional advantage of "defer" iscsi changes on the server.

This will warrant a bump to 0.8 I believe

The PR against 25.10 middleware that adds the backend support for the "iscsi defer" changes is

truenas/middleware#16614

@mrstux mrstux changed the title Added TryDeferIscsiApiCallArray 0.8.0 Add support for server side "iscsi defer" Jun 6, 2025
@mrstux mrstux changed the title 0.8.0 Add support for server side "iscsi defer" [DRAFT] 0.8.0 Add support for server side "iscsi defer" Jun 6, 2025
@mrstux
Copy link
Collaborator Author

mrstux commented Jun 6, 2025

Currently seeing errors in tests which seem to be triggered by this functionality

Error: Failed creating instance from image: No path for activated TrueNAS volume: puddle/se/incus-tests/1f342170-94ef-476e-a58d-abe5423749ff/images/740e1d5a9081219bca1aba573865c264f00804c593e2f13e05486dd78eb92eb4_ext4

@mrstux
Copy link
Collaborator Author

mrstux commented Jun 10, 2025

This error seems to have been caused by the iscsid on the client system crashing. A restart fixed it.

A general issue with TNC is that share iscsi activate doesn't seem to handle errors very well, for example, if there zvol doesn't have a target then nothing occurs, or if there is an error, it should check if there is a target before reporting the error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants