Manhpd/upgrade to angular 19 #102
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manhpd
commented
Apr 13, 2025
manhpd
commented
- Upgrade angular to version 19
- Upgrade multiple library to recent version
- Change the app to zoneless
… manhpd/upgrade-to-angular-19
domiverse
reviewed
Dec 14, 2025
| export class AlbumComponent { | ||
| album$ = this.store.album$; | ||
| album = toSignal(this.store.album$,{ initialValue: null }); | ||
|
|
There was a problem hiding this comment.
Nếu template đọc album trực tiếp (album()), kiểm tra null trước khi truy cập thuộc tính: album()?.name hoặc dùng ngIf để tránh lỗi.
| standalone: false | ||
| }) | ||
| export class ClickStopPropagationDirective { | ||
| @HostListener('click', ['$event']) onClick(e: MouseEvent) { |
There was a problem hiding this comment.
Cách dùng @directive + @HostListener để đóng gói một hành vi click nhỏ thành directive, giúp component gọn hơn và tăng khả năng tái sử dụng
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.