don't set clang target as its already handled in bindgen by default#16
Merged
robin-nitrokey merged 1 commit intotrussed-dev:mainfrom Sep 18, 2024
Merged
Conversation
03b00f6 to
4fe8cef
Compare
Member
|
Good catch, thank you! I’ve squashed the commits, added a changelog entry and will merge after adding some CI checks to the repository. |
4fe8cef to
aa64d08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no need to set the clang_target as its already being defaulted to TARGET. Besides passing the rust target is wrong for some targets as llvm's targets are slightly different (see this mapping) causing it to fail on some TARGETS with: