Fix screen.lua.sample off-by-one error and function name #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Function is named get_sighandle() rather than get_signhandle() and accepts indices starting with 0. This is correctly documented in opendkim-lua man page. Attempting to access signatures outside the range leads to errors.
futatuki
added a commit
to futatuki/OpenDKIM
that referenced
this pull request
Mar 4, 2024
…screen-lua-sample
futatuki
added a commit
to futatuki/OpenDKIM
that referenced
this pull request
Mar 11, 2024
…screen-lua-sample
futatuki
added a commit
to futatuki/OpenDKIM
that referenced
this pull request
Apr 26, 2024
…screen-lua-sample Fix sample script screen.lua.sample, off-by-one error and typo in function name.
futatuki
added a commit
to futatuki/OpenDKIM
that referenced
this pull request
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function is named get_sighandle() rather than get_signhandle() and accepts indices starting with 0.
This is correctly documented in opendkim-lua man page. Attempting to access signatures outside the range leads to errors.