-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Per request sign algorithm (A part of issue #6) #202
base: develop
Are you sure you want to change the base?
Per request sign algorithm (A part of issue #6) #202
Conversation
I didn't care opendkim-testkey, so I'll update it later. |
Done. However library function |
As commit message of commit 2fb3b18 is wrong, rebase latest 2 commit. |
0abd128
to
5c47d2c
Compare
Done. |
I separated lookup functions and tables from However I found it has been provided in libopendkim/dkim-tables.h, so I'll remove last 2 commit and I'll use I think lookups for |
It turned out that all I believe those nametables are worth exposed. Also, there is no bad side effect if names of the tables are renamed by adding prefix ' |
…ield * opendkim/opendkim.c (): Add forward declaration for dkimf_lookup_strtoint (dkimf_add_signrequest): Extract sign algorithm from 4th field in key table and set it in the sign request. (dkimf_config_load): Allow 4th field in key table value.
…-sign-algorithm
5c47d2c
to
a05fead
Compare
Now, it uses lookup table for |
…-sign-algorithm
…-sign-algorithm
…-sign-algorithm Extend KeyTable to hold optionally signing algorithm per key entry.
This extends KeyTable value fields as the issue comment #6 (comment) said.
With an extended KeyTable and lua script, I could confirm that the milter can both rsa-sha256 and ed25519-sha256 signature.
(Edit)
Now, this PR depends on PR #207 for conversion table for
dkim_alg_t
anddkim_canon_t
(but not including those commits).