Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dkimf_db_walk: explicitly treat DKIMF_DB_MEMCACHE as unsupported db type. #219

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

futatuki
Copy link

This saves incorrect usage of DKIMF_DB_MEMCACHE from assertion failure addressing to unknown DB type error, although it still need that caller should handle the error properly. (see issue #218)

…ype.

This saves incorrect usage of DKIMF_DB_MEMCACHE from assertion failure
addressing to unknown DB type error, although it still need that
caller should handle the error properly.
* opendkim/opendkim-db.c, opendkim/opendkim-db.h
 (dkimf_can_db_walk): New.
does not support db walk operation

* opendkim/opendkim.c (dkimf_config_load): As above
@futatuki futatuki force-pushed the db_walk_avoid_abort branch from 80228d5 to 565d38c Compare October 4, 2024 16:52
@futatuki
Copy link
Author

futatuki commented Oct 4, 2024

... although it still need that caller should handle the error properly.

Now it check if the db supports dkimf_db_walk operation before calling it.

futatuki added a commit to futatuki/OpenDKIM that referenced this pull request Oct 7, 2024
…id_abort

This saves incorrect usage of DKIMF_DB_TYPE_MEMCACHE from assertion
failure addressing to unknown DB type error, and avoid execute
verification of signing table on loading configurations. (See
the issue trusteddomainproject#218)

trusteddomainproject#218
trusteddomainproject#219
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant