Skip to content

feat: add gradle kotlin dsl support #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2025

Conversation

ruromero
Copy link
Collaborator

@ruromero ruromero commented Mar 10, 2025

Description

Add support for Gradle Kotlin DSL

Related issue:

Checklist

  • I have followed this repository's contributing guidelines.
  • I will adhere to the project's code of conduct.

@ruromero ruromero force-pushed the kotlin-dsl branch 2 times, most recently from 7829927 to 0cf5fd5 Compare March 10, 2025 16:37
Copy link
Member

@carlosthe19916 carlosthe19916 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Considering my limited knowledge of this. Hopefully I will get more familiarized with it soon

@TomerFi
Copy link
Contributor

TomerFi commented Mar 11, 2025

Hi @ruromero and @carlosthe19916

I'm trying to explore the Auto-Me-Bot failure. I can't say why it failed to begin with, except that it ended with a timeout. I found the original timed-out event in GitHub and attempted a re-delivery. In AWS logs, I keep seeing the bot is unable to pick up your config:

image

image

Can you please try amending the commit and force-pushing? I'll watch the logs.

cc @zvigrinberg

Signed-off-by: Ruben Romero Montes <[email protected]>
@ruromero
Copy link
Collaborator Author

@TomerFi thanks for taking the time. I have just force-pushed and it failed after 14s

@TomerFi
Copy link
Contributor

TomerFi commented Mar 11, 2025

That's weird, I'm still seeing no config:
image

Can it be that someone changed the permissions? We expect this:
image

But I can't check for this repository because the app was installed at the organization level, and I don't have permission to check there. Can we ask someone from the org to verify the permissions?
image

@TomerFi
Copy link
Contributor

TomerFi commented Mar 11, 2025

Ok, it's not that. I asked Swati to confirm that the app was configured correctly.

I'm sorry about this, I'll keep investigating it and report back. Please don't let this block this PR.

@ruromero
Copy link
Collaborator Author

That's fine. We can keep the PR open for some time as it is not blocking.
Let us know if you need us to do any changes/tests or re-install the App.

@TomerFi
Copy link
Contributor

TomerFi commented Mar 14, 2025

The app was reinstalled in the org, but I can no longer see the original event and redeliver it. Can you please change something? A PR title or body modification should do.

@ruromero ruromero changed the title feat: adding gradle kotlin dsl support feat: add gradle kotlin dsl support Mar 14, 2025
@ruromero
Copy link
Collaborator Author

I just updated the title and failed again. Let me know if you need me to trigger it again.
Thanks

@TomerFi
Copy link
Contributor

TomerFi commented Mar 15, 2025

@ruromero The Bug was fixed. Thank you very much for your cooperation.

@ruromero
Copy link
Collaborator Author

Excellent, thanks
@carlosthe19916 do you mind reviewing the PR and approve if you agree with the changes?

@ruromero ruromero enabled auto-merge (squash) March 15, 2025 15:06
@ruromero ruromero disabled auto-merge March 17, 2025 14:41
@ruromero ruromero merged commit 094f04d into trustification:main Mar 17, 2025
5 checks passed
@ruromero ruromero deleted the kotlin-dsl branch March 17, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants