fix: make sure npm is enabled only if package-lock.json is enabled #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Feria <[email protected]>
carlosthe19916
force-pushed
the
hotfix/npm-package-lock.json
branch
from
525f604 to
1741240
Compare
|
Closing in favor of #114 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change should be the counter part of trustification/exhort-javascript-api#151
which will avoid npm projects being analyzed unless the owner of the code has the file package-lock.json.
In order to detect whether or not there is a package-lock.json file next to the manifest file (package.json), an additional parameter needs to be passed to the
exhortApi. The additional param is the directory path where the manifest file lies.Checklist
Additional information