-
Notifications
You must be signed in to change notification settings - Fork 27
chore: dev env only - dashboard updates #1891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThe PR customizes the development Grafana deployment by swapping in Trustify dashboards, enabling anonymous access, and removing legacy dashboard provisioning. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @helio-frota - I've reviewed your changes and found some issues that need to be addressed.
Blocking issues:
- Syntax error in method chaining for setting interval. (link)
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `common/infrastructure/src/otel.rs:150` </location>
<code_context>
.expect("Unable to build metrics exporter.");
let reader = PeriodicReader::builder(exporter).build();
+ .with_interval()Duration::from_secs(1)
let resource = Resource::builder()
</code_context>
<issue_to_address>
Syntax error in method chaining for setting interval.
There's a misplaced parenthesis and missing dot in the method chain, which will cause a compilation error. The correct syntax is `.with_interval(Duration::from_secs(1))`.
</issue_to_address>
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
ee838ce
to
06cb6bc
Compare
@sourcery-ai review and please add to the description that now we have some equivalent dashboards when comparing with v1. thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @helio-frota - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
![]() ![]() @sourcery-ai review the images/screenshot in this comment 👍 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1891 +/- ##
==========================================
+ Coverage 67.96% 68.06% +0.10%
==========================================
Files 364 365 +1
Lines 22864 23065 +201
Branches 22864 23065 +201
==========================================
+ Hits 15539 15700 +161
- Misses 6458 6486 +28
- Partials 867 879 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary by Sourcery
Configure Grafana in the development environment to use new Trustify dashboards and enable anonymous access
Chores: