Skip to content

chore: dev env only - dashboard updates #1891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2025

Conversation

helio-frota
Copy link
Collaborator

@helio-frota helio-frota commented Jul 22, 2025

Summary by Sourcery

Configure Grafana in the development environment to use new Trustify dashboards and enable anonymous access

Chores:

  • Replace default Grafana traces and metrics dashboards with Trustify-specific dashboards
  • Add Trustify performance and SLOs dashboard definitions
  • Enable anonymous authentication for Grafana in dev compose configuration
  • Remove legacy metrics.json dashboard file

Copy link

sourcery-ai bot commented Jul 22, 2025

Reviewer's Guide

The PR customizes the development Grafana deployment by swapping in Trustify dashboards, enabling anonymous access, and removing legacy dashboard provisioning.

File-Level Changes

Change Details Files
Replace default Grafana dashboards with Trustify-specific dashboards
  • Updated volume mounts to reference trustify-traces.json, trustify-performance.json, and trustify-slos.json
  • Removed provisioning of the legacy metrics.json dashboard
etc/deploy/compose/compose-otel.yaml
etc/deploy/compose/grafana/dashboards/trustify-performance.json
etc/deploy/compose/grafana/dashboards/trustify-slos.json
etc/deploy/compose/grafana/dashboards/metrics.json
Enable anonymous authentication in development Grafana
  • Toggled GF_AUTH_ANONYMOUS_ENABLED from false to true in environment variables
etc/deploy/compose/compose-otel.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @helio-frota - I've reviewed your changes and found some issues that need to be addressed.

Blocking issues:

  • Syntax error in method chaining for setting interval. (link)
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments

### Comment 1
<location> `common/infrastructure/src/otel.rs:150` </location>
<code_context>
         .expect("Unable to build metrics exporter.");

     let reader = PeriodicReader::builder(exporter).build();
+        .with_interval()Duration::from_secs(1)

     let resource = Resource::builder()
</code_context>

<issue_to_address>
Syntax error in method chaining for setting interval.

There's a misplaced parenthesis and missing dot in the method chain, which will cause a compilation error. The correct syntax is `.with_interval(Duration::from_secs(1))`.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@helio-frota
Copy link
Collaborator Author

@sourcery-ai review and please add to the description that now we have some equivalent dashboards when comparing with v1. thanks 👍

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @helio-frota - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@helio-frota helio-frota requested review from mrrajan and ctron July 22, 2025 18:10
@helio-frota
Copy link
Collaborator Author

2025-07-18_11-36 2025-07-18_12-24_1

@sourcery-ai review the images/screenshot in this comment 👍

Copy link

codecov bot commented Jul 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.06%. Comparing base (0ad43eb) to head (06cb6bc).
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1891      +/-   ##
==========================================
+ Coverage   67.96%   68.06%   +0.10%     
==========================================
  Files         364      365       +1     
  Lines       22864    23065     +201     
  Branches    22864    23065     +201     
==========================================
+ Hits        15539    15700     +161     
- Misses       6458     6486      +28     
- Partials      867      879      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@helio-frota helio-frota added this pull request to the merge queue Jul 24, 2025
Merged via the queue into trustification:main with commit 82c3738 Jul 24, 2025
9 checks passed
@helio-frota helio-frota deleted the otel-dev-updates branch July 24, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants