Skip to content

chore: another round of dependency cleanups #1895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2025

Conversation

ctron
Copy link
Contributor

@ctron ctron commented Jul 24, 2025

Summary by Sourcery

Clean up dependency configurations by removing unused entries, normalizing version specifications, upgrading PostgreSQL crates to v0.19.0, and tidying the xtask workspace manifest.

Chores:

  • Remove unused dependencies and feature flags from Cargo.toml
  • Normalize version specification for sanitize-filename
  • Upgrade postgresql_archive, postgresql_embedded, and postgresql_commands to 0.19.0
  • Clean up xtask/Cargo.toml by removing unused dependencies and feature declarations

@ctron ctron requested a review from mrizzi July 24, 2025 08:05
Copy link

sourcery-ai bot commented Jul 24, 2025

Reviewer's Guide

This PR tidies up project and xtask workspace dependencies by removing obsolete crates, relaxing version constraints, and bumping PostgreSQL-related versions to streamline and modernize our Cargo manifests.

File-Level Changes

Change Details Files
Cleaned up dependencies in main Cargo.toml
  • Removed unused crates (env_logger, nu-ansi-term, percent-encoding, reedline, serde_with, static-files, walker-extras)
  • Relaxed version constraint on sanitize-filename
  • Upgraded postgresql_archive/embedded/commands from v0.18.0 to v0.19.0
Cargo.toml
Pruned xtask workspace manifest
  • Removed default features section
  • Dropped unused workspace dependencies (async-trait, nu-ansi-term, reedline, reqwest, trustify-module-fundamental)
xtask/Cargo.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ctron - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ctron ctron enabled auto-merge July 24, 2025 08:06
Copy link

codecov bot commented Jul 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.29%. Comparing base (da07c38) to head (898da01).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1895      +/-   ##
==========================================
+ Coverage   68.06%   68.29%   +0.23%     
==========================================
  Files         365      365              
  Lines       23063    23063              
  Branches    23063    23063              
==========================================
+ Hits        15698    15752      +54     
+ Misses       6486     6429      -57     
- Partials      879      882       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ctron ctron added this pull request to the merge queue Jul 24, 2025
Merged via the queue into trustification:main with commit b6089dd Jul 24, 2025
9 of 10 checks passed
@ctron ctron deleted the feature/deps_cleanup_1 branch July 24, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants