Skip to content

Support compiling tron raw json from DApp #4449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Support compiling tron raw json from DApp #4449

wants to merge 4 commits into from
+190 −4

Conversation

10gic
Copy link
Contributor

@10gic 10gic commented Jul 10, 2025

Description

Support compiling tron raw json from DApp.

How to test

Types of changes

Checklist

  • Create pull request as draft initially, unless its complete.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • If there is a related Issue, mention it in the description.

@satoshiotomakan
Copy link
Collaborator

Hi @gupnik, can we please consider adding support for JSON generation in #4434?

@satoshiotomakan
Copy link
Collaborator

@10gic thank you for the PR btw. We won't merge this PR due to ongoing Rust migration, but we'll use your code as an example in #4434 or in a separate PR

@10gic
Copy link
Contributor Author

10gic commented Jul 10, 2025 •
edited
Loading

@satoshiotomakan Is this related to PR #4434? That is for Tezos chain, while this one is for Tron chain.

@satoshiotomakan
Copy link
Collaborator

@10gic sorry for confusion, didn't notice the difference... Reviewing the PR

satoshiotomakan
satoshiotomakan reviewed Jul 10, 2025
View reviewed changes
Copy link
Collaborator

@satoshiotomakan satoshiotomakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing to add please

@FATBARB84 FATBARB84 mentioned this pull request Jul 10, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satoshiotomakan satoshiotomakan satoshiotomakan left review comments

@gupnik gupnik Awaiting requested review from gupnik gupnik is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@10gic @satoshiotomakan