-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add TLS ConfigMap parameter #269
base: main
Are you sure you want to change the base?
Conversation
Update ODH and RHOAI overlays
PR image build and manifest generation completed successfully! 📦 PR image: 🗂️ CI manifests |
@ruivieira: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: RobGeada The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This PR adds a new field to the TrustyAI operator configuration
ConfigMap
calledtls
with can be eitherenabled
ordisabled
.tls: enabled
, payload processors will be registered with ModelMesh ashttps
. This is the default value if the configuration key is missing.tls: disabled
, payload processors will be registered ashttp
. This is the opt-in value, only set if explicitly changed on the config map.Two overlays were also updated:
odh
rhoai
tls
disabled
enabled
kServeServerless
enabled
disabled
4.14
registry.redhat.io/openshift4/ose-oauth-proxy@sha256:ab112105ac37352a2a4916a39d6736f5db6ab4c29bad4467de8d613e80e9bb33
This allows for:
odh
: TLS-disabled and KServe integration enabledrhoai
: TLS-enabled and KServe integration disabled and a pinned OAuth proxy image