feat: simplify expo plugin #25
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The expo config plugin edits:
The problem with the current plugin is that the values for the infoPlist are configurable, as in they do not support passing custom values instead of the dummy:
While we can make the plugin accept arguments and dynamically use those, the better solution is let library users use existing expo tools to configure what already can be configured and only use the config plugin to configure those that can't be.
The change in this pr gets rid of the edits in:
and only updates the AppDelegate.
The iOS infoPlist and AndroidManifest changes can be implemented by library users through the following config in
app.json
, 'app.config.(js/ts)':Here is an example with
app.config.(js/ts)
. If you do not need background syncs, then one can remove the related configs