-
Notifications
You must be signed in to change notification settings - Fork 10
refactor: add Rbush/Flatbush impl in SegmentTree #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
refactor: add Rbush/Flatbush impl in SegmentTree #105
Conversation
Signed-off-by: Akhilender Bongirwar <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@akhilender-bongirwar nice video, clearly shows the difference! on a plane so might be a bit before merge. Can you confirm there are no new DRC errors? (DRC errors check that the implementation is correct by making sure lines don't overlap improperly) Personally I like to always check against keyboard5 because it tends to catch any subtle bugs. tyty!!! |
Keyboard 3 is also a good one if keyboard5 is too slow to run for you.
|
🎉🎈 @akhilender-bongirwar has been awarded $10 by tscircuit! 🎈🎊 |
Please visit Algora to complete your tip via Stripe. |
It seems like there may be performance degradation again. Compare this page with your branch? You can also slow down your CPU using the performance tab to help get worse, more measurable time |
2025-04-27.00-44-44.mp4@seveibar please check |
Thank you. Sure, here it is 2025-04-27.00-49-43.mp4 |
@seveibar why aren't the workflows running? |
@akhilender-bongirwar not sure, will be looking at this later today, thanks for the vid, definitely helps!! |
Signed-off-by: Akhilender Bongirwar <[email protected]>
@seveibar, works now |
Some delays getting to this, if you can show it has a large performance impact via a side-by-side screenshot with https://unraveller.vercel.app (before/after), then I can merge, otherwise need to turn to some important cache optimizations, we will eventually get this in either way most likely!!! |
cannot tell large performance impact but the above are the before/after results. Do you want me to add any other components screenshots too? |
@seveibar sorry for delay I was busy with my end semester exams. Please let me know if any further changes are required here |
Signed-off-by: Akhilender Bongirwar <[email protected]>
@akhilender-bongirwar yes sorry for the delay, im going to be working to merge this in the next couple days |
@seveibar please check |
@akhilender-bongirwar sprry for the delay, on the issues tab we currently have some major bugs so im trying to be careful to not switch the implementation and accidentally introduce new ones |
fixes #102
/claim #102
2025-04-26.16-00-44.mp4