add bug report, add script to download bug reports #125
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| try { | ||
| const response = await fetch(downloadUrl) |
There was a problem hiding this comment.
The code doesn't check the HTTP response status before attempting to parse JSON. If the API returns a non-200 status (like 404 or 500), this could lead to confusing errors. Consider adding a response status check before processing:
if (!response.ok) {
console.error(`API returned error: ${response.status} ${response.statusText}`);
process.exit(1);
}This would provide clearer error messages and fail gracefully when the API request doesn't succeed.
| try { | |
| const response = await fetch(downloadUrl) | |
| try { | |
| const response = await fetch(downloadUrl) | |
| if (!response.ok) { | |
| console.error(`API returned error: ${response.status} ${response.statusText}`) | |
| process.exit(1) | |
| } | |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
| const data = await response.json() | ||
| fs.writeFileSync( | ||
| jsonFilePath, | ||
| JSON.stringify(data.autorouting_bug_report, null, 2), |
There was a problem hiding this comment.
The script is writing data.autorouting_bug_report to the JSON file, but based on the example bug report JSON in this PR, the response data appears to be at the root level, not nested under an autorouting_bug_report property. This mismatch could cause the generated fixture file to reference incorrect or missing data. Consider either:
- Modifying the script to save
datadirectly instead ofdata.autorouting_bug_report, or - Confirming the actual API response structure to ensure it matches the expected format
This will ensure the fixture files correctly reference the bug report data structure.
| JSON.stringify(data.autorouting_bug_report, null, 2), | |
| JSON.stringify(data, null, 2), |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
No description provided.