Fix bugreport1, use better force calculation using nearest-point-on-segment #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
seveibar
commented
May 14, 2025
seveibar
commented
- new endpoint force calculation approach
- update to endpoint force approach
- add boundary padding for hdpolyline
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+472
to
+473
| const baseForceMargin = this.viaDiameter / 2 | ||
| const forceMargin = baseForceMargin + this.BOUNDARY_PADDING |
There was a problem hiding this comment.
The MultiHeadPolyLineIntraNodeSolver2 class is using this.BOUNDARY_PADDING but this property isn't declared or initialized in this class. Since this class extends MultiHeadPolyLineIntraNodeSolver, it should properly declare and initialize this property.
Please add:
BOUNDARY_PADDING: numberas a class property, and initialize it in the constructor with:
this.BOUNDARY_PADDING = params.hyperParameters?.BOUNDARY_PADDING ?? 0.05This matches the implementation in the parent class and ensures consistent behavior.
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.