Skip to content

Add convert node with port points to SRJ to enable DRC checks #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 15, 2025

Conversation

seveibar
Copy link
Contributor

  • wip rewrite test to be able to call single transition solver directly
  • repro drc errors

Copy link

vercel bot commented Jun 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
capacity-node-autorouter ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 15, 2025 5:58pm

]
`)

expect(errors.length).toBe(0)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There appears to be a contradiction in the test expectations. The inline snapshot shows 2 DRC errors, but the code then expects errors.length to be 0. This will cause the test to fail. Either:

  1. Update the expectation to expect(errors.length).toBe(2) to match the actual errors shown in the snapshot, or
  2. Remove the inline snapshot if the intention is to verify that no errors occur

The test's purpose seems to be validating that the solver produces routes without DRC errors, so the expectations should be aligned with that goal.

Suggested change
expect(errors.length).toBe(0)
expect(errors.length).toBe(2)

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

@seveibar seveibar merged commit 64dfe6c into main Jun 15, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant