Factor out distributed SMC logic #2303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2303 +/- ##
==========================================
+ Coverage 90.85% 91.13% +0.28%
==========================================
Files 20 20
Lines 11993 11868 -125
Branches 2330 2296 -34
==========================================
- Hits 10896 10816 -80
+ Misses 606 577 -29
+ Partials 491 475 -16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jeromekelleher
force-pushed
the
refactor-smck-distributed
branch
from
873149b to
6d37fc7
Compare
Thrashing about Clean up some loose ends for hull usage Debugging stuff with allocs
Tidy up
jeromekelleher
force-pushed
the
refactor-smck-distributed
branch
from
5a06136 to
d1981e9
Compare
jeromekelleher
force-pushed
the
refactor-smck-distributed
branch
from
d1981e9 to
ee2b6c0
Compare
|
I'm going to merge this as it should be significant improvement in terms of code readability, and I think it also fixes a few memory leaks and performance issues. I'll follow up with issues for what remains in order to release the SMC(k) code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring SMC k logic together in one place as part of #2294