Fix error handling for streaming RPCs #116
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue where grpcbox ignores errors that are returned from the callback function of a streaming RPC. This happened both on RPCs with streaming and non-streaming output, though the behaviour was different: For non-streaming output, grpcbox always returned a generic error, generated in `grpcbox_stream.erl` line 425 (on this commit). For streaming output, errors were completely ignored and the stream was closed without an error indication to the client. Also fixes a small issue where grpcbox passed incorrect ServerInfo to streaming interceptors for RPCs with only streaming output.
Owner
|
@JonathanArns sorry for not getting to this sooner. Is there a decent way to add a test for this by chance? |
Author
|
Hi, yes I can come up with a test. |
Owner
|
I just realized you are at Ericsson. Funny enough I just emailed Rickard Green to check if grpcbox was still in use :) |
Owner
|
And I would love additional tests, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where grpcbox ignores errors that are returned from the callback function of a streaming RPC. This happened both on RPCs with streaming and non-streaming output, though the behaviour was different: For non-streaming output, grpcbox always returned a generic error, generated in
grpcbox_stream.erlline 425 (on this commit).For streaming output, errors were completely ignored and the stream was closed without an error indication to the client.
Also fixes a small issue where grpcbox passed incorrect ServerInfo to streaming interceptors for RPCs with only streaming output.