Remove undefined behaviour and make compatible with apple/clang #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made two separate commits which can be cherry-picked.
Remove non-ASM statement in naked function
Non-ASM statements in naked functions are undefined behaviour, only basic ASM statements can safely be included in naked functions. Clang won't even compile
(void)rsp;
statements, so I replaced them with__attribite__((unused))
.https://stackoverflow.com/a/47343399
Add missing names for Apple and clang
Apple OSes doesn't have MAP_STACK or MAP_GROWSDOWN, so I replaced them with 0. They seem to be missing the
threads.h
header andasm
keyword, so made simple defines for them that works for both gcc and clang.Also, clang (and probably other compilers) prepend underscore to their labels.