Fix some issues that occur on 64-bit clients #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
had to manually change Int32 to Int in the new LionTamer modules.
Owner
|
Wow, sorry about that delay; I just found the "Pull Requests" section on github, and saw this pending. I'll take a look and merge it in very soon now. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that using Int32 is not correct on 64-bit clients. The zookeeper client uses a C int type that corresponds to Int in Haskell (it's 32-bit or 64-bit depending on the architecture), so I changed Int32 to Int.
I also used preallocated buffer buffer for some actions instead of allocating each time.
I'd like to start using the LionTamer stuff in production, but I think I need to clean it up a bit first. One thing is I need to remove the putStrLn lines.