Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ARM64 architecture in Docker build and push action #67

Merged
merged 4 commits into from
Jun 22, 2024

Conversation

niklhut
Copy link
Contributor

@niklhut niklhut commented May 26, 2024

This PR updates the Docker build and push action to include the linux/arm64 platform in addition to linux/amd64. Previously, the build configuration only targeted amd64, which made it impossible to pull the image on Macs with ARM architecture chips.

With this change, the Docker images will be built for both amd64 and arm64 architectures, ensuring compatibility across a wider range of devices, including ARM-based Macs.

@Rdeisenroth
Copy link
Member

Hmm seems like Github thinks for some reason the image is too big like this :/

@niklhut
Copy link
Contributor Author

niklhut commented Jun 22, 2024

Well, the failure seems to be because the image could not be uploaded to ghcr.io:

ERROR: failed to solve: failed to push ghcr.io/tudalgo/algotex:pr-67: unexpected status from POST request to https://ghcr.io/v2/tudalgo/algotex/blobs/uploads/: 403 Forbidden

According to this page https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token this is because PRs from forks can only get a read permission for packages, so an upload fails.

@Rdeisenroth Rdeisenroth merged commit ba973fa into tudalgo:master Jun 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants