send: Acquire LIDs from PNs by USync during message enc #952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
purpshell
force-pushed
the
feature/usync-lids-send
branch
from
c63c748 to
06c3389
Compare
Contributor
Author
|
UPDATE: The only real considerations for this seem to be batching the userInfo requests in amounts of 500 for every 20 seconds each. Not sure if this is something that we need to implement or not, maybe this could be an issue in large groups (though not sure if that is even a consideration for this logic here) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based off the already existing #947, all it does is experiment with fetching missing LIDs from the usync protocol
NOTE: This is experimental and is mostly a proposal