Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/winner admin response #69

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+10 −6
Open

Fix/winner admin response #69

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2373528
fix: return unauthorized response for winner endpoint
nguernse Aug 2, 2024
d45aee4
fix: return 404 error for no winning proposals
nguernse Aug 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: return unauthorized response for winner endpoint
@nguernse
nguernse committed Aug 2, 2024
commit 2373528840617a4677d30c765d81f956536fdeb1
4 changes: 2 additions & 2 deletions routes/winner.ts
View file
Original file line number Diff line number Diff line change
@@ -4,11 +4,11 @@ import config from '../config'

const router = express.Router();

router.get("/", async (req, res) => {
router.get("/", async (req, res) => {
const { userEmail } = req.user;
const { admins } = config;
if (!admins.includes(userEmail)) {
res.status(401).json({message: 'Unauthorized'})
return res.status(401).json({ message: 'Unauthorized' })
}
try {
const winner = await WinnerService.getWinner();