optimization: use mcopy in String() and Bytes() #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize String and Bytes Handling with MCOPY
Summary:
This PR introduces an optimization for the
String()andBytesoperations by leveraging theMCOPYopcode, resulting in reduced gas costs.Details:
I've been working on
MCOPYsupport for the Filecoin EVM as part of the FIL-Builders team. I noticed that the current implementation ofString()andBytesin this repo can benefit fromMCOPYto achieve better gas efficiency.Gas Comparison:
This optimization was validated by running the Forge test suite. Below is a summary of the key results:
With Optimization (This PR):
Current
mainBranch:Improvements
test_decodeFixedArray_ReadCbor(): 4472 → 4402test_decodeStringWithWeirdChar_ReadCbor(): 1122 → 1052test_decodeString_ReadCbor(): 1195 → 1125Notes
This PR improves efficiency without changing the core logic or functionality.
Let me know if there's anything you'd like to add or modify!