Skip to content

feat: accept None as a param type #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 1, 2024
Merged

feat: accept None as a param type #75

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f63a71a
feat: accept None as a param type
notrab Oct 30, 2024
093e812
add test
notrab Oct 30, 2024
6dde130
fix: provider for None
notrab Oct 30, 2024
d01208d
fix: use id 2
notrab Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,7 +496,9 @@ async fn execute(cursor: &Cursor, sql: String, parameters: Option<&PyTuple>) ->
Some(parameters) => {
let mut params = vec![];
for param in parameters.iter() {
let param = if let Ok(value) = param.extract::<i32>() {
let param = if param.is_none() {
libsql_core::Value::Null
} else if let Ok(value) = param.extract::<i32>() {
libsql_core::Value::Integer(value as i64)
} else if let Ok(value) = param.extract::<f64>() {
libsql_core::Value::Real(value)
Expand Down
10 changes: 10 additions & 0 deletions tests/test_suite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,16 @@ def test_params(provider):
res = cur.execute("SELECT * FROM users")
assert (1, "[email protected]") == res.fetchone()

def test_none_param(provider):
conn = connect(provider, ":memory:")
cur = conn.cursor()
cur.execute("CREATE TABLE users (id INTEGER, email TEXT)")
cur.execute("INSERT INTO users VALUES (?, ?)", (1, None))
cur.execute("INSERT INTO users VALUES (?, ?)", (1, "[email protected]"))
res = cur.execute("SELECT * FROM users ORDER BY id")
results = res.fetchall()
assert results[0] == (1, None)
assert results[1] == (2, "[email protected]")

@pytest.mark.parametrize("provider", ["libsql", "sqlite"])
def test_fetchmany(provider):
Expand Down
Loading