libsql: Fix build on older Rust toolchains #1870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haaawk
approved these changes
Dec 6, 2024
haaawk
reviewed
Dec 6, 2024
libsql/src/sync.rs
Outdated
| @@ -309,7 +309,7 @@ impl SyncContext { | |||
| async fn read_metadata(&mut self) -> Result<()> { | |||
| let path = format!("{}-info", self.db_path); | |||
|
|
|||
| if !std::fs::exists(&path).map_err(SyncError::io("metadata file exists"))? { | |||
| if !Path::new(&path).exists() { | |||
There was a problem hiding this comment.
This hides potential errors. Is there an API that does not hide them and works for older build?
There was a problem hiding this comment.
try_exists seems to do the job and is there since 1.63
The JavaScript SDK is unfortunately stuck with Rust 1.78: tursodatabase/libsql-js#104 We should fix that, but since that's hard, let's just once again paper over it by fixing build on older Rust toolchains.
penberg
force-pushed
the
fix-build-with-old-toolchain
branch
from
99bccec to
7ddc4f9
Compare
haaawk
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JavaScript SDK is unfortunately stuck with Rust 1.78:
tursodatabase/libsql-js#104
We should fix that, but since that's hard, let's just once again paper over it by fixing build on older Rust toolchains.