Allow forking without the group flag#1007
Open
m0hossam wants to merge 3 commits intotursodatabase:mainfrom
Open
Allow forking without the group flag#1007m0hossam wants to merge 3 commits intotursodatabase:mainfrom
m0hossam wants to merge 3 commits intotursodatabase:mainfrom
Conversation
m0hossam
force-pushed
the
fork-no-group
branch
from
13d8b31 to
513eed9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1004
From what I understand (could be mistaken, first timer here): we should allow
turso db create --from-db somedbeven if user has multiple groups and hasn't specified one. The created DB will be within the same group of the seed DB.We also check if a group was specified anyway then it should match the seed DB's group.