Add support for cursor pagination to show audit logs command #984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PThorpe92
force-pushed
the
PThorpe92/audit_logs
branch
from
904ab28 to
a90a801
Compare
PThorpe92
force-pushed
the
PThorpe92/audit_logs
branch
from
a90a801 to
3cd107e
Compare
PThorpe92
force-pushed
the
PThorpe92/audit_logs
branch
from
3cd107e to
b312575
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix the audit logs, supporting cursor based pagination is going to be crucial to avoid large offset/limit clauses. The API is backwards compatible but the CLI should support this as well.