Skip to content

Conversation

@gigagrug
Copy link
Contributor

For modernc.org/sqlite default boolean returns int which is accurate to SQLite.
For https://github.com/mattn/go-sqlite3 default boolean returns bool which I think makes more sense for golang sdk.
I can change test to change to check bool instead if you think the test itself is generally good.
For #53

@PThorpe92
Copy link
Collaborator

PThorpe92 commented Oct 23, 2025

So this test probably won't pass yet right? until the next release of turso_core, because I just fixed this upstream in tursodatabase/turso#3804 the other day.

but yeah this is definitely good to have 👍

@gigagrug
Copy link
Contributor Author

gigagrug commented Oct 23, 2025

Yeah you're right it shouldn't pass now. Also I was wondering what you think about what true false returns in golang as mentioned above.

@PThorpe92
Copy link
Collaborator

that's tough.. I think because it's going to probably have to be 1 or 0 because that's how it's going to be returned from core.. otherwise we'd probably have to convert all those 1's and 0's right?. Not sure how the other driver does it.

@gigagrug
Copy link
Contributor Author

idk this is the best I can offer: https://github.com/mattn/go-sqlite3/blob/master/sqlite3_type.go.
It don't think it really matters I personally regularly use modernc.org/sqlite anyways.
When I was testing it was a difference I came across that I found interesting.
Whatever you think is best I'm cool with 👍.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants