Skip to content

Conversation

@LeMikaelF
Copy link
Contributor

@LeMikaelF LeMikaelF commented Oct 7, 2025

This will catch regressions of #3436, and also opens the door to more complex FROM clauses by allowing the leftmost table in a FROM clause to be nested.

Example of a generated interaction:

 INFO execute_interaction_turso{conn_index=2 interaction=INSERT INTO fortuitous_clique SELECT * FROM (SELECT * FROM (SELECT * FROM (SELECT * FROM (SELECT * FROM (SELECT * FROM (SELECT * FROM fortuitous_clique WHERE TRUE) WHERE TRUE) WHERE TRUE) WHERE TRUE) WHERE TRUE) WHERE TRUE) WHERE TRUE; -- 2}: limbo_sim::runner::execution: 174: 

To test this, I reverted dc231abb2e0fe81cb1e96ab32febe7749c5794c8 locally, and the simulator was able to catch the bug:

Error: failed with error: 'InternalError("Assertion 'table sparkling_darity should have the expected content' failed: expected 16 rows but got 109 for table sparkling_darity")'

While adding this property, I found a bug which Alperen then fixed, so some of the commits on this branch are by him.

@LeMikaelF LeMikaelF changed the title Add InsertSelectNested property Simulator: add InsertSelectNested property Oct 7, 2025
@LeMikaelF LeMikaelF force-pushed the sim-nested-inserts branch 2 times, most recently from 20130df to db629ea Compare October 9, 2025 09:41
@nyrkio
Copy link

nyrkio bot commented Oct 9, 2025

Commit: 20130df

No performance changes detected. 🚀

Nyrkiö

@nyrkio
Copy link

nyrkio bot commented Oct 9, 2025

Commit: db629ea

No performance changes detected. 🚀

Nyrkiö

@LeMikaelF LeMikaelF force-pushed the sim-nested-inserts branch 2 times, most recently from 1609c96 to 8893fa4 Compare October 9, 2025 09:58
@nyrkio
Copy link

nyrkio bot commented Oct 9, 2025

Commit: 20130df

No performance changes detected. 🚀

Nyrkiö

@nyrkio
Copy link

nyrkio bot commented Oct 9, 2025

Commit: db629ea

No performance changes detected. 🚀

Nyrkiö

@LeMikaelF LeMikaelF force-pushed the sim-nested-inserts branch 2 times, most recently from 58e5e94 to f9c15aa Compare October 9, 2025 11:11
@nyrkio
Copy link

nyrkio bot commented Oct 9, 2025

Commit: 58e5e94

No performance changes detected. 🚀

Nyrkiö

2 similar comments
@nyrkio
Copy link

nyrkio bot commented Oct 9, 2025

Commit: 58e5e94

No performance changes detected. 🚀

Nyrkiö

@nyrkio
Copy link

nyrkio bot commented Oct 9, 2025

Commit: 58e5e94

No performance changes detected. 🚀

Nyrkiö

@nyrkio
Copy link

nyrkio bot commented Oct 9, 2025

Commit: f9c15aa

No performance changes detected. 🚀

Nyrkiö

@nyrkio
Copy link

nyrkio bot commented Oct 9, 2025

Commit: 3b00099

No performance changes detected. 🚀

Nyrkiö

@LeMikaelF LeMikaelF marked this pull request as ready for review October 9, 2025 13:26
@LeMikaelF LeMikaelF requested a review from penberg as a code owner October 9, 2025 13:26
@nyrkio
Copy link

nyrkio bot commented Oct 9, 2025

Commit: 3b00099

No performance changes detected. 🚀

Nyrkiö

@nyrkio
Copy link

nyrkio bot commented Oct 9, 2025

Commit: 6cb0d78

No performance changes detected. 🚀

Nyrkiö

1 similar comment
@nyrkio
Copy link

nyrkio bot commented Oct 9, 2025

Commit: 6cb0d78

No performance changes detected. 🚀

Nyrkiö

@jussisaurio
Copy link
Collaborator

I don't think this needs to be a separate property. Our arbitrary SELECT should sometimes generate subqueries, and since the existing INSERT ... SELECT uses an arbitrary select, it will also sometimes exercise this path. We already have properties like TableHasExpectedContent which should then catch the same issue as this property would. Make sense?

@LeMikaelF
Copy link
Contributor Author

LeMikaelF commented Oct 13, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants