-
Couldn't load subscription status.
- Fork 579
Simulator: add InsertSelectNested property #3625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
20130df to
db629ea
Compare
|
Commit: 20130df No performance changes detected. 🚀 |
|
Commit: db629ea No performance changes detected. 🚀 |
1609c96 to
8893fa4
Compare
|
Commit: 20130df No performance changes detected. 🚀 |
|
Commit: db629ea No performance changes detected. 🚀 |
58e5e94 to
f9c15aa
Compare
|
Commit: 58e5e94 No performance changes detected. 🚀 |
2 similar comments
|
Commit: 58e5e94 No performance changes detected. 🚀 |
|
Commit: 58e5e94 No performance changes detected. 🚀 |
|
Commit: f9c15aa No performance changes detected. 🚀 |
f9c15aa to
3b00099
Compare
|
Commit: 3b00099 No performance changes detected. 🚀 |
|
Commit: 3b00099 No performance changes detected. 🚀 |
3b00099 to
6cb0d78
Compare
|
Commit: 6cb0d78 No performance changes detected. 🚀 |
1 similar comment
|
Commit: 6cb0d78 No performance changes detected. 🚀 |
|
I don't think this needs to be a separate property. Our arbitrary |
|
Yes, absolutely. I realized this just yesterday. I'll make this PR a draft while I modify it.
…________________________________
De : Jussi Saurio ***@***.***>
Envoyé : 13 octobre 2025 07:15
À : tursodatabase/turso ***@***.***>
Cc : Mikaël Francoeur ***@***.***>; Author ***@***.***>
Objet : Re: [tursodatabase/turso] Simulator: add InsertSelectNested property (PR #3625)
[https://avatars.githubusercontent.com/u/22619982?s=20&v=4]jussisaurio left a comment (tursodatabase/turso#3625)<#3625 (comment)>
I don't think this needs to be a separate property. Our arbitrary SELECT should sometimes generate subqueries, and since the existing INSERT ... SELECT uses an arbitrary select, it will also sometimes exercise this path. We already have properties like TableHasExpectedContent which should then catch the same issue as this property would. Make sense?
—
Reply to this email directly, view it on GitHub<#3625 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFO5REUGVTKB32ARGN477O33XOCWZAVCNFSM6AAAAACIRG2XHSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGOJXGA3DSOBSGE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|

This will catch regressions of #3436, and also opens the door to more complex FROM clauses by allowing the leftmost table in a FROM clause to be nested.
Example of a generated interaction:
To test this, I reverted
dc231abb2e0fe81cb1e96ab32febe7749c5794c8locally, and the simulator was able to catch the bug:While adding this property, I found a bug which Alperen then fixed, so some of the commits on this branch are by him.