core/incremental: Fix JOIN with USING keyword #3628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
USING is a convenient way to express an equijoin. Instead of writing a.id = b.id, you can just JOIN USING (a), and the database will find a table with that name in both tables. It is not hard to support this with our operator, since it is ultimately an equijoin, but we have to do the work to deduplicate the columns when producing the final schema. Fixes tursodatabase#3362
glommer
requested review from
jussisaurio,
penberg and
pereman2
as code owners
penberg
changed the title
penberg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
USING is a convenient way to express an equijoin. Instead of writing a.id = b.id, you can just JOIN USING (a), and the database will find a table with that name in both tables.
It is not hard to support this with our operator, since it is ultimately an equijoin, but we have to do the work to deduplicate the columns when producing the final schema.
Fixes #3362