Throw an error in case duplicate CTE names are found

[RS2007]

• Fixes bug Parser should reject CTEs with duplicate names #3674
• With this fix:

turso>  WITH t AS (SELECT 1), t AS (SELECT 2) SELECT * FROM x;
  × Parse error: duplicate WITH table name: t

[LeMikaelF]

Ideally there would be a test for this in one of the .test suites.

[RS2007]

Yup looks like there is one here: https://chromium.googlesource.com/external/github.com/sqlite/sqlite/%2B/refs/heads/new-dbconfig-options/test/with1.test

do_catchsql_test 3.2 {
CREATE TABLE t2(x INTEGER);
WITH tmp(a) AS (SELECT * FROM t1),
tmp(a) AS (SELECT * FROM t1)
SELECT * FROM tmp;
} {1 {duplicate WITH table name: tmp}}

[LeMikaelF]

But that's SQLite, I meant, ideally it would be in one of the test suites that Turso runs.

[RS2007]

Got it, added a test to the select.test file

[LeMikaelF]

This looks good! The only think I see is that this fix is slightly more permissive than SQLite, because it allows things like this:

with t as (select 1), t as (select 1) select 1;

whereas SQLite does not. Personally I think this is fine.

[LeMikaelF]

@PThorpe92 I don't have merge rights, but this PR looks good to me.

[PThorpe92]

Looks good, but as @LeMikaelF mentioned, can you add a regression test for the exact query this fixes? similar to this:

turso/testing/select.test

Line 1065 in 00e6ed8

# https://github.com/tursodatabase/turso/issues/3667 regression test

can be in the same file testing/select.test

[RS2007]

Looks good, but as @LeMikaelF mentioned, can you add a regression test for the exact query this fixes? similar to this:

turso/testing/select.test

Line 1065 in 00e6ed8

# https://github.com/tursodatabase/turso/issues/3667 regression test

can be in the same file testing/select.test

Sure, the actual chromium repos seem to have this in a with1.test file, should I keep it that way, or just append it to select.test ?