core/translate: prevent aliasing internal subquery identifiers #3767
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

closes #3620
SQLite displays column names that are otherwise un-named (or would contain whatever internal identifier otherwise), as

columnxwhere x is the index into the result columns.Turso previously did this, and just used the internal subquery identifier:

this PR swaps out the internal ident:

and prevents a user from explicitly either
ASorElidedalias'ing a table or selectingidentifier.*using the internal subquery prefix, preventing issues like the one referenced in #3620