Simulator: clean up code and separate code generation and code model #3775
+1,451
−1,705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`Remaining` to a metrics file
|
Nyrkiö Report for Commit: a710623 No performance changes detected. Remember that Nyrkiö results become more precise when more commits are merged. So please check back in a few days. |
will track `Interaction` instead of `Interactions` in the Plan, this change will impossibilitate the serialization of the InteractionPlan with Serde Json. - make --load just load the previous cli args
pedrocarlo
force-pushed
the
sim-refactor-clean
branch
from
79f24c7 to
a710623
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a separate PR to not pollute the main ideas proposed in #3774 . This also disables
watch modefor now, and loads the previous cli options in--load