validate default constraint contains only constant expressions #3788
Conversation
|
Nyrkiö Report for Commit: 20f8c62
|
pedrocarlo
force-pushed
the
default-constraint-validate
branch
6 times, most recently
from
f9fcc9b to
7f71300
Compare
| } | ||
|
|
||
| #[derive(Debug, Clone, Copy, PartialEq, Eq, Default)] | ||
| pub enum ConstantFlags { |
There was a problem hiding this comment.
Please document what this does
There was a problem hiding this comment.
added some more docs
| Expr::Parenthesized(exprs) => { | ||
| let new_flag = if matches!(flags, ConstantFlags::ExprFunction { .. }) { | ||
| ConstantFlags::ExprFunction { | ||
| // disallow ID inside parametrized |
There was a problem hiding this comment.
parametrized? also, why?
There was a problem hiding this comment.
CREATE TABLE t(x DEFAULT (adfgdfg)); VS CREATE TABLE t(x DEFAULT adfgdfg);
The first is parenthesized and the second one is not. The second one is interpreted as a String literal in this case, despite being an Identifier in the AST, so it is allowed and constant. This also applies to functions and other expressions like CASE
I thought at first this was a parser bug, but I compared the AST output with sqlite3-parser and the AST is correct. It's just some crazy rule SQLite decided to follow. Maybe it is a compatibility thing with some other DBMS.
| arg.is_constant( | ||
| resolver, | ||
| ConstantFlags::ExprFunction { | ||
| // disallow ID in arguments |
There was a problem hiding this comment.
maybe the Parenthesized is already enough because you need to add a Parenthesis to have functions in DEFAULT, but I just to be sure I did this here as well.
pedrocarlo
force-pushed
the
default-constraint-validate
branch
from
7f71300 to
20f8c62
Compare
2 participants
Closes #3636
Did something similar to SQLite and added a flag when checking for a constant expression, that changes the behaviour slightly for functions and identifiers.
Also asked Claude to generate some tests to check our
DEFAULTbehaviour