Prepared stmt bugs #3813
Draft
Prepared stmt bugs #3813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
mvcc
translation/planning
vdbe
Storage
Perf/Benchmarks
labels
jussisaurio
force-pushed
the
prepared-stmt-bugs
branch
from
b11703e to
8b13aee
Compare
motivation: try to catch bugs related to prepared statement reuse.
For repreparing prepared statements, we need to know what the required version is, because the connection may already be on that version, but the statement was compiled with an older one.
Simply checking `schema_version` is not enough to determine that schema is up to date because of rolled-back schema updates. Generation is incremented whenever the schema is changed, either forward or backward.
This may cause an unintended rollback of the transaction which we don't want, instead we want the statement to be reprepared.
A prepared statement may have been compiled with a stale schema version, but the connection itself might already be up to date. In this case the connection doesn't need to clone db.schema.
As mentioned in a previous commit message, the schema version alone is insufficient to determine that a statement was compiled with a stale schema, because schema version `N` may refer to two different schemas if one of them was rolled back.
this way we can remove the optionality of the field in LimboError::SchemaUpdated and prepared statements are re-prepared properly in the MVCC context too.
jussisaurio
force-pushed
the
prepared-stmt-bugs
branch
from
8b13aee to
d160864
Compare
jussisaurio
force-pushed
the
prepared-stmt-bugs
branch
from
b4a00ea to
ccb8b8d
Compare
|
Nyrkiö Report for Commit: ccb8b8d No performance changes detected. Remember that Nyrkiö results become more precise when more commits are merged. So please check back in a few days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.