feat: adding check for unquoted literals in values()

[RS2007]

Closes #3949
Closes #4018

turso> values(asdf);
  × Parse error: Unquoted identifier in VALUES clause: asdf
  
turso> select * from users;
┌────┬──────┐
│ id │ name │
├────┼──────┤
│  1 │ jack │
├────┼──────┤
│  2 │ jill │
└────┴──────┘
  turso> select id, (values(name)) as name_again from users;
┌────┬────────────┐
│ id │ name_again │
├────┼────────────┤
│  1 │ jack       │
├────┼────────────┤
│  2 │ jill       │
└────┴────────────┘

[LeMikaelF]

This masks the underlying issue, which is that Turso doesn't resolve column names in values clauses, but it's an still improvement. At least now Turso will throw an error instead of silently coercing and inserting a column name to a string.

For the test failure, you could use do_execsql_test_regex with a regex alternation, and leave a comment that it's temporary behaviour.

My opinion is that we could merge this, as long as we have a Github issue to track the issue that Turso can't resolve column names in VALUES clauses.

[RS2007]

This masks the underlying issue, which is that Turso doesn't resolve column names in values clauses, but it's an still improvement. At least now Turso will throw an error instead of silently coercing and inserting a column name to a string.

For the test failure, you could use do_execsql_test_regex with a regex alternation, and leave a comment that it's temporary behaviour.

My opinion is that we could merge this, as long as we have a Github issue to track the issue that Turso can't resolve column names in VALUES clauses.

The fix that I have up currently, resolves the string using the outer query table.