feat(core/translate): Implement SQLite min/max special-case for bare columns #4288
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the correct handling of bare columns in
GROUP BYqueries that contain exactly oneMINorMAXaggregate, as described in #3444.How does it work?
MINorMAXaggregate in theGROUP BYqueriesNULLhandling:NULL, bare columns are updated for eachNULLrow, so the lastNULLrow wins.NULLvalues, bare columns are updated only when a value is strictly less than (forMIN) or greater than (forMAX) the current value. As a result, the first row that establishes the min/max wins.Previous bytecode
New bytecode
Motivation and context
Fixes #3444.
Currently, Turso does not have this special-case handling for bare columns:
SQLite does:
Description of AI Usage
Claude Sonnet 4.5 was heavily used in this PR. I relied on it to understand the existing group-by flow, from query planning through bytecode generation, and then used it iteratively to generate most of the code until I reached the desired solution. It was also used to create some of the test cases.