perf/sorter: sort pointers instead of records, use arena allocation #4344
+232
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jussisaurio
force-pushed
the
optimize-sorter-perf
branch
from
fc7287d to
25c6962
Compare
jussisaurio
changed the title
jussisaurio
force-pushed
the
optimize-sorter-perf
branch
3 times, most recently
from
881bd9b to
eff510e
Compare
1. Use bump arena for in-memory records - Allows contiguous allocation and bulk deallocate - Allows sorting pointers instead of sorting large SortableImmutableRecord structs which pay a large memmove penalty 2. Use boxed records for on-disk chunk heap: avoids the same memmove problem
jussisaurio
force-pushed
the
optimize-sorter-perf
branch
from
5b9a0f9 to
f8421b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beef
Testing
ran
RUSTFLAGS="-Zsanitizer=address" cargo +nightly test --package turso_core sorter --target aarch64-apple-darwinResults
Locally I got -20% on this clickbench query:
SELECT WatchID, ClientIP, COUNT(*) AS c, SUM(IsRefresh), AVG(ResolutionWidth) FROM hits GROUP BY WatchID, ClientIP ORDER BY c DESC LIMIT 10;.Unfortunately the clickbench CI benchmark is noisy, but It looks like queries with sorting that used to take the longest now take less time. Very scientific.