Remove TursoDBFactory #4362
Open
Remove TursoDBFactory #4362
+1
−94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeMikaelF
changed the title
LeMikaelF
force-pushed
the
java-caching-policy
branch
2 times, most recently
from
b0278ce to
dc737a4
Compare
The factory previously cached TursoDB instances by URL, but this was unsafe because TursoDB implements AutoCloseable. If one caller closed a cached instance, other callers sharing that instance would be left with an unusable reference. Each call to TursoDBFactory.open() now creates a new TursoDB instance, allowing callers to safely manage their own lifecycle.
LeMikaelF
force-pushed
the
java-caching-policy
branch
from
dc737a4 to
1846cb5
Compare
![turso-bot[bot]](https://avatars.githubusercontent.com/in/2434523?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes
TursoDBFactory, since its purpose was to cache instances ofTursoDB, but they are not safe to share, because they implementAutoCloseable. See the associated issue for a discussion of this.Description of AI Usage
I fed #2071 into Claude Code, and it wrote the code
Closes #2071
@seonWKim, if you want to review this please