datetime: redo for full features #4365
Draft
+1,258
−427
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SELECT typeof(strftime('%Y', 'not-a-valid-date'));Support modifiers for UnixEpoch and JulianDay functions #602
Motivation and context
I originally had this pr: #4104
But then I saw: #4345 that did things better.
However although my code uses some code in the PR I couldn't add all the code without breaking compatibility. Specifically the faster parser.
There is also this PR: #4331
Storing date in struct is closer to how SQLite handles date but I personally found too much reliance on the Chronos create a lot of bugs with compatibility.
Description of AI Usage
I used Google Gemini Pro.