-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: From Twitter to X #40706
base: main
Are you sure you want to change the base?
Docs: From Twitter to X #40706
Conversation
b210dab
to
fb4fa09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased the PR and made a small change. Otherwise, the PR looks good to me. Thanks @louismaximepiton for this one 🙏
I’ve added a comment regarding the change from site/layouts/partials/icons/twitter.svg
to site/layouts/partials/icons/x.svg
, but I don’t think it’s a major concern. Just in case we have to use another one.
I haven’t identified any other changes needed on our side or any rendering issues.
Assigning it to @mdo and @XhmikosR for final checks if needed. To embed in v5.3.4 (or any other v5.3.x).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just got a doubt with this SVG that has a viewBox="0 0 1200 1227"
. The previous one was viewBox="0 0 512 416.32"
.
No issue in terms of rendering, but I was wondering if we chose the right source.
Description
Change all Twitter references to X but for history.
Motivation & Context
Twitter has changed its name since a year now.
Type of changes
Checklist
npm run lint
)Live previews
Related issues
Closes #40737