Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: From Twitter to X #40706

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Docs: From Twitter to X #40706

wants to merge 5 commits into from

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Aug 7, 2024

Description

Change all Twitter references to X but for history.

Motivation & Context

Twitter has changed its name since a year now.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Closes #40737

@louismaximepiton louismaximepiton requested a review from a team as a code owner August 7, 2024 13:10
@XhmikosR XhmikosR marked this pull request as draft August 8, 2024 04:45
@coliff coliff mentioned this pull request Aug 16, 2024
6 tasks
@louismaximepiton louismaximepiton marked this pull request as ready for review October 9, 2024 06:49
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased the PR and made a small change. Otherwise, the PR looks good to me. Thanks @louismaximepiton for this one 🙏

I’ve added a comment regarding the change from site/layouts/partials/icons/twitter.svg to site/layouts/partials/icons/x.svg, but I don’t think it’s a major concern. Just in case we have to use another one.

I haven’t identified any other changes needed on our side or any rendering issues.

Assigning it to @mdo and @XhmikosR for final checks if needed. To embed in v5.3.4 (or any other v5.3.x).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just got a doubt with this SVG that has a viewBox="0 0 1200 1227". The previous one was viewBox="0 0 512 416.32".
No issue in terms of rendering, but I was wondering if we chose the right source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Twitter Icon to X Logo Across Bootstrap Website
3 participants