Open
Conversation
Member
|
I haven't reviewed the code yet, but this PR seems to bring a more logical order to the focusable elements:
It feels more intuitive to inspect the code before attempting to copy it. I'll wait for @patrickhlauke feedback before reviewing the actual code :) |
Member
patrickhlauke
left a comment
There was a problem hiding this comment.
sure, works for me (even though on smaller viewports this may look a bit odd with the page scrolling to show the full code, and then focus going back up to the stackblitz/copy buttons - even more so when navigating in reverse).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change the focus order of the examples.
Issue when the window is very small on long file names. See here the JS example on small viewports.
Motivation & Context
Better accessibility on focus order to have the content before the copy button.
Type of changes
Checklist
npm run lint)Live previews
Related issues
NA